Do not exclude newer Python versions #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
=======================================
Coverage 87.03% 87.03%
=======================================
Files 7 7
Lines 216 216
Branches 27 27
=======================================
Hits 188 188
Misses 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
pyproject.toml, the Python version that the Python SDK supports is restricted. While it has a lower limit>=3.9, there is also an upper limit<3.13. The idea seems to be that we test the SDK against new Python versions and then raise this limit if they are compatible and we have fixed any incompatibilities. While this is a good strategy in theory, it fails in practice because we don't update the limit often enough. For example, Python 3.13 was released two months ago and customers were not able to use our Python SDK with it yet. Since it's unlikely that future minor Python releases break functionality that the SDK uses, I think we should remove any upper limit.